Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #409

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Drop support for Python 3.6.

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Copy link
Contributor Author

adrianeboyd commented Nov 8, 2023

The last tokenizers release to support python 3.6 only has linux wheels, which is causing build headaches in wheelwright.

Actually it appears to be newer version of rust exposing a bug in tokenizers which prevents the latest supported version of tokenizers for python 3.6 from being compiled in windows/macos. It's fixed in a newer release for python 3.7+.

@adrianeboyd adrianeboyd merged commit 12f17d3 into explosion:master Nov 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant